Skip to content

feat: implement dynamic module lb policy - #8702

Closed
jukie wants to merge 31 commits into
envoyproxy:mainfrom
jukie:dym-lb-policy
Closed

feat: implement dynamic module lb policy#8702
jukie wants to merge 31 commits into
envoyproxy:mainfrom
jukie:dym-lb-policy

Conversation

@jukie

@jukie jukie commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Implements support for dynamic module lb policy

Which issue(s) this PR fixes:

Fixes #8736

Release Notes: Yes

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@netlify

netlify Bot commented Apr 9, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 83d3c13
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69f2ef671b7f75000812b9a8
😎 Deploy Preview https://deploy-preview-8702--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.28947% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.68%. Comparing base (8fa767a) to head (83d3c13).
⚠️ Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/clustersettings.go 71.69% 8 Missing and 7 partials ⚠️
internal/gatewayapi/backendtrafficpolicy.go 82.00% 3 Missing and 6 partials ⚠️
internal/xds/translator/cluster.go 79.31% 3 Missing and 3 partials ⚠️
internal/xds/translator/translator.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8702      +/-   ##
==========================================
- Coverage   74.69%   74.68%   -0.01%     
==========================================
  Files         251      251              
  Lines       40257    40343      +86     
==========================================
+ Hits        30068    30129      +61     
- Misses       8123     8135      +12     
- Partials     2066     2079      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jukie added 4 commits April 9, 2026 17:38
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Comment thread api/v1alpha1/dynamic_module_types.go Outdated
jukie and others added 4 commits April 9, 2026 22:09
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
jukie and others added 4 commits April 12, 2026 21:41
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
jukie marked this pull request as ready for review April 13, 2026 14:30
@jukie
jukie requested a review from a team as a code owner April 13, 2026 14:30
@jukie jukie changed the title Implement dynamic module lb policy feat: implement dynamic module lb policy Apr 13, 2026
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78609b8c92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/gatewayapi/backendtrafficpolicy.go Outdated
jukie and others added 2 commits April 13, 2026 18:46
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie

jukie commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

/retest

jukie and others added 5 commits April 14, 2026 20:49
Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie

jukie commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75fece3809

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/v1alpha1/loadbalancer_types.go
@jukie

jukie commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dec7e3d46d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/gatewayapi/clustersettings.go Outdated
jukie and others added 2 commits April 23, 2026 08:00
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie

jukie commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0a65f4ccb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/v1alpha1/loadbalancer_types.go
@jukie

jukie commented Apr 25, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@jukie jukie added this to the v1.8.0-rc.1 Release milestone Apr 25, 2026
Comment thread release-notes/current.yaml Outdated
jukie and others added 3 commits April 24, 2026 19:00
Co-authored-by: zirain <zirain2009@gmail.com>
Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
@jukie jukie removed this from the v1.8.0-rc.1 Release milestone Apr 27, 2026
Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label May 30, 2026
@github-actions github-actions Bot closed this Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for dynamic module loadbalancing policy

3 participants